diff --git a/api/send.go b/api/send.go index 08531b696d2d4f60acf36dd81ef05f6d3994afc7..3c6cc0178451408221692bb801458e69b4350ef8 100644 --- a/api/send.go +++ b/api/send.go @@ -50,7 +50,6 @@ func (c *Client) SendUnsafe(m message.Send, param params.Unsafe) ([]id.Round, func (c *Client) SendCMIX(msg format.Message, recipientID *id.ID, param params.CMIX) (id.Round, ephemeral.Id, error) { jww.INFO.Printf("SendCMIX(%s)", string(msg.GetContents())) - c.OnSend(1) return c.network.SendCMIX(msg, recipientID, param) } @@ -59,7 +58,6 @@ func (c *Client) SendCMIX(msg format.Message, recipientID *id.ID, // round ID of the round the payload was sent or an error if it fails. func (c *Client) SendManyCMIX(messages []message.TargetedCmixMessage, params params.CMIX) (id.Round, []ephemeral.Id, error) { - c.OnSend(uint32(len(messages))) return c.network.SendManyCMIX(messages, params) } @@ -75,13 +73,3 @@ func (c *Client) NewCMIXMessage(contents []byte) (format.Message, error) { msg.SetContents(contents) return msg, nil } - -// OnSend performs a bucket addition on a call to Client.SendCMIX or -// Client.SendManyCMIX, updating the bucket for the amount of messages sent. -func (c *Client) OnSend(messages uint32) { - rateLimitingParam := c.storage.GetBucketParams().Get() - c.storage.GetBucket().AddWithExternalParams(messages, - rateLimitingParam.Capacity, rateLimitingParam.LeakedTokens, - rateLimitingParam.LeakDuration) - -} diff --git a/network/message/sendCmix.go b/network/message/sendCmix.go index 5847e4e15631424d0b4165d11d49e0ec980cf98d..3c48ac49f2c9f624fc40f61d2d80744401e7fe7d 100644 --- a/network/message/sendCmix.go +++ b/network/message/sendCmix.go @@ -187,6 +187,7 @@ func sendCmixHelper(sender *gateway.Sender, msg format.Message, elapsed, numRoundTries) jww.INFO.Print(m) events.Report(1, "MessageSend", "Metric", m) + onSend(1, session) return id.Round(bestRound.ID), ephID, nil } else { jww.FATAL.Panicf("Gateway %s returned no error, but failed "+ @@ -198,3 +199,13 @@ func sendCmixHelper(sender *gateway.Sender, msg format.Message, return 0, ephemeral.Id{}, errors.New("failed to send the message, " + "unknown error") } + +// OnSend performs a bucket addition on a call to Manager.SendCMIX or +// Manager.SendManyCMIX, updating the bucket for the amount of messages sent. +func onSend(messages uint32, session *storage.Session) { + rateLimitingParam := session.GetBucketParams().Get() + session.GetBucket().AddWithExternalParams(messages, + rateLimitingParam.Capacity, rateLimitingParam.LeakedTokens, + rateLimitingParam.LeakDuration) + +} diff --git a/network/message/sendManyCmix.go b/network/message/sendManyCmix.go index 04b833344bf42e524cba6756bc4770785ffad18a..a99af6ddec241eb2f0b261f17b6a800f53fab5ca 100644 --- a/network/message/sendManyCmix.go +++ b/network/message/sendManyCmix.go @@ -203,6 +203,7 @@ func sendManyCmixHelper(sender *gateway.Sender, "in round %d", ephemeralIDsString, recipientString, bestRound.ID) jww.INFO.Print(m) events.Report(1, "MessageSendMany", "Metric", m) + onSend(uint32(len(msgs)), session) return id.Round(bestRound.ID), ephemeralIDs, nil } else { jww.FATAL.Panicf("Gateway %s returned no error, but failed to "+