From 09356d969263e5e32a2cabee03ed244d5df74b96 Mon Sep 17 00:00:00 2001
From: "Richard T. Carback III" <rick.carback@gmail.com>
Date: Fri, 1 Jul 2022 21:04:59 +0000
Subject: [PATCH] Fix error where a known id of a message without any services
matching would suppress garbled message processing
---
cmix/message/handler.go | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/cmix/message/handler.go b/cmix/message/handler.go
index 842337d65..6a5baf554 100644
--- a/cmix/message/handler.go
+++ b/cmix/message/handler.go
@@ -182,15 +182,14 @@ func (h *handler) handleMessageHelper(ecrMsg format.Message, bundle Bundle) bool
services, exists := h.get(
identity.Source, ecrMsg.GetSIH(), ecrMsg.GetContents())
- if exists {
+ // If the id doesn't exist or there are no services for it, then
+ // we want messages to be reprocessed as garbled.
+ if exists && len(services) != 0 {
for _, t := range services {
jww.DEBUG.Printf("handleMessage service found: %s, %s",
ecrMsg.Digest(), t)
go t.Process(ecrMsg, identity, round)
}
- if len(services) == 0 {
- jww.WARN.Printf("Empty service list for %s", ecrMsg.Digest())
- }
return true
}
--
GitLab