From 3cf2e785a41eff3ad33cc587f654ef4633dff30c Mon Sep 17 00:00:00 2001 From: josh <josh@elixxir.io> Date: Fri, 27 May 2022 11:33:29 -0700 Subject: [PATCH] Publicize RegisterNodeComms interface --- cmix/interface.go | 2 +- cmix/nodes/interfaces.go | 4 ++-- cmix/nodes/register.go | 2 +- cmix/nodes/registrar.go | 4 ++-- cmix/nodes/request.go | 2 +- cmix/nodes/utils_test.go | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/cmix/interface.go b/cmix/interface.go index 863530bff..c03dc1296 100644 --- a/cmix/interface.go +++ b/cmix/interface.go @@ -299,5 +299,5 @@ type ClientErrorReport func(source, message, trace string) type clientCommsInterface interface { followNetworkComms SendCmixCommsInterface - nodes.registerNodeCommsInterface + nodes.RegisterNodeCommsInterface } diff --git a/cmix/nodes/interfaces.go b/cmix/nodes/interfaces.go index 34824da33..ba5809881 100644 --- a/cmix/nodes/interfaces.go +++ b/cmix/nodes/interfaces.go @@ -62,9 +62,9 @@ type MixCypher interface { MakeClientGatewayAuthMAC(salt, digest []byte) []byte } -// registerNodeCommsInterface is a sub-interface of client.Comms containing +// RegisterNodeCommsInterface is a sub-interface of client.Comms containing // the send function for registering with a cMix node. -type registerNodeCommsInterface interface { +type RegisterNodeCommsInterface interface { SendRequestClientKeyMessage(host *connect.Host, message *pb.SignedClientKeyRequest) (*pb.SignedKeyResponse, error) } diff --git a/cmix/nodes/register.go b/cmix/nodes/register.go index f225cef16..827e67b2b 100644 --- a/cmix/nodes/register.go +++ b/cmix/nodes/register.go @@ -114,7 +114,7 @@ func registerNodes(r *registrar, s session, stop *stoppable.Single, // registerWithNode serves as a helper for registerNodes. It registers a user // with a specific in the client's NDF. -func registerWithNode(sender gateway.Sender, comms registerNodeCommsInterface, +func registerWithNode(sender gateway.Sender, comms RegisterNodeCommsInterface, ngw network.NodeGateway, s session, r *registrar, rng csprng.Source, stop *stoppable.Single) error { diff --git a/cmix/nodes/registrar.go b/cmix/nodes/registrar.go index 1d076e525..2bfa2cb5d 100644 --- a/cmix/nodes/registrar.go +++ b/cmix/nodes/registrar.go @@ -36,7 +36,7 @@ type registrar struct { session session sender gateway.Sender - comms registerNodeCommsInterface + comms RegisterNodeCommsInterface rng *fastRNG.StreamGenerator c chan network.NodeGateway @@ -45,7 +45,7 @@ type registrar struct { // LoadRegistrar loads a Registrar from disk or creates a new one if it does not // exist. func LoadRegistrar(session session, sender gateway.Sender, - comms registerNodeCommsInterface, rngGen *fastRNG.StreamGenerator, + comms RegisterNodeCommsInterface, rngGen *fastRNG.StreamGenerator, c chan network.NodeGateway) (Registrar, error) { kv := session.GetKV().Prefix(prefix) diff --git a/cmix/nodes/request.go b/cmix/nodes/request.go index a172c2824..b75f7801c 100644 --- a/cmix/nodes/request.go +++ b/cmix/nodes/request.go @@ -26,7 +26,7 @@ import ( // requestKey is a helper function which constructs a ClientKeyRequest message. // This message is sent to the passed gateway. It will further handle the // request from the gateway. -func requestKey(sender gateway.Sender, comms registerNodeCommsInterface, +func requestKey(sender gateway.Sender, comms RegisterNodeCommsInterface, ngw network.NodeGateway, s session, r *registrar, rng io.Reader, stop *stoppable.Single) (*cyclic.Int, []byte, uint64, error) { diff --git a/cmix/nodes/utils_test.go b/cmix/nodes/utils_test.go index 895999b6f..5c97dadf3 100644 --- a/cmix/nodes/utils_test.go +++ b/cmix/nodes/utils_test.go @@ -192,7 +192,7 @@ func (m mockSession) GetTransmissionRegistrationValidationSignature() []byte { ///////////////// Mock Comms Interface /////////////////////////////////////// /////////////////////////////////////////////////////////////////////////////// -// Mock client comms object adhering to registerNodeCommsInterface for testing. +// Mock client comms object adhering to RegisterNodeCommsInterface for testing. type MockClientComms struct { rsaPrivKey *rsa.PrivateKey dhPrivKey *cyclic.Int -- GitLab