diff --git a/fileTransfer/connect/utils_test.go b/fileTransfer/connect/utils_test.go index 5910ac657f1262c741c64d7acd42155885c23452..b707e548ec2bbe96d43b9d7d3fa6f19205bee424 100644 --- a/fileTransfer/connect/utils_test.go +++ b/fileTransfer/connect/utils_test.go @@ -140,12 +140,10 @@ func (m *mockCmix) SendWithAssembler(*id.ID, cmix.MessageAssembler, panic("implement me") } -func (m *mockCmix) AddIdentity(*id.ID, time.Time, bool) { panic("implement me") } -func (m *mockCmix) AddIdentityWithHistory(id *id.ID, validUntil, beginning time.Time, persistent bool) { - panic("implement me") -} -func (m *mockCmix) RemoveIdentity(*id.ID) { panic("implement me") } -func (m *mockCmix) GetIdentity(*id.ID) (identity.TrackedID, error) { panic("implement me") } +func (m *mockCmix) AddIdentity(*id.ID, time.Time, bool) { panic("implement me") } +func (m *mockCmix) AddIdentityWithHistory(*id.ID, time.Time, time.Time, bool) { panic("implement me") } +func (m *mockCmix) RemoveIdentity(*id.ID) { panic("implement me") } +func (m *mockCmix) GetIdentity(*id.ID) (identity.TrackedID, error) { panic("implement me") } func (m *mockCmix) AddFingerprint(_ *id.ID, fp format.Fingerprint, mp message.Processor) error { m.Lock() diff --git a/fileTransfer/e2e/utils_test.go b/fileTransfer/e2e/utils_test.go index 1c33203a16665ed99d99560477b1ca5f06c78a5e..a7f50a19525cd2360dfb698fbca8281f2572d520 100644 --- a/fileTransfer/e2e/utils_test.go +++ b/fileTransfer/e2e/utils_test.go @@ -142,12 +142,10 @@ func (m *mockCmix) SendWithAssembler(*id.ID, cmix.MessageAssembler, panic("implement me") } -func (m *mockCmix) AddIdentity(*id.ID, time.Time, bool) { panic("implement me") } -func (m *mockCmix) AddIdentityWithHistory(id *id.ID, validUntil, beginning time.Time, persistent bool) { - panic("implement me") -} -func (m *mockCmix) RemoveIdentity(*id.ID) { panic("implement me") } -func (m *mockCmix) GetIdentity(*id.ID) (identity.TrackedID, error) { panic("implement me") } +func (m *mockCmix) AddIdentity(*id.ID, time.Time, bool) { panic("implement me") } +func (m *mockCmix) AddIdentityWithHistory(*id.ID, time.Time, time.Time, bool) { panic("implement me") } +func (m *mockCmix) RemoveIdentity(*id.ID) { panic("implement me") } +func (m *mockCmix) GetIdentity(*id.ID) (identity.TrackedID, error) { panic("implement me") } func (m *mockCmix) AddFingerprint(_ *id.ID, fp format.Fingerprint, mp message.Processor) error { m.Lock() diff --git a/fileTransfer/groupChat/utils_test.go b/fileTransfer/groupChat/utils_test.go index b1f5f18d4e37d8a638caafb87aa739f9ee1aa337..a616d65c19783c0bfd9789fb0e3399a61a253656 100644 --- a/fileTransfer/groupChat/utils_test.go +++ b/fileTransfer/groupChat/utils_test.go @@ -137,12 +137,10 @@ func (m *mockCmix) SendWithAssembler(*id.ID, cmix.MessageAssembler, panic("implement me") } -func (m *mockCmix) AddIdentity(*id.ID, time.Time, bool) { panic("implement me") } -func (m *mockCmix) AddIdentityWithHistory(id *id.ID, validUntil, beginning time.Time, persistent bool) { - panic("implement me") -} -func (m *mockCmix) RemoveIdentity(*id.ID) { panic("implement me") } -func (m *mockCmix) GetIdentity(*id.ID) (identity.TrackedID, error) { panic("implement me") } +func (m *mockCmix) AddIdentity(*id.ID, time.Time, bool) { panic("implement me") } +func (m *mockCmix) AddIdentityWithHistory(*id.ID, time.Time, time.Time, bool) { panic("implement me") } +func (m *mockCmix) RemoveIdentity(*id.ID) { panic("implement me") } +func (m *mockCmix) GetIdentity(*id.ID) (identity.TrackedID, error) { panic("implement me") } func (m *mockCmix) AddFingerprint(_ *id.ID, fp format.Fingerprint, mp message.Processor) error { m.Lock() diff --git a/fileTransfer/manager.go b/fileTransfer/manager.go index f4ef20744369953459f0f49c1fc24c5b57e18726..0e8a92694366138286469acb472f60dfedb1247f 100644 --- a/fileTransfer/manager.go +++ b/fileTransfer/manager.go @@ -170,7 +170,6 @@ type Storage interface { // transfers already existed, they are loaded from storage and queued to resume // once manager.startProcesses is called. func NewManager(params Params, user FtE2e) (FileTransfer, error) { - kv := user.GetStorage().GetKV() // Create a new list of sent file transfers or load one if it exists diff --git a/fileTransfer/store/received.go b/fileTransfer/store/received.go index 6ec51f2e0188bc4d1ab05b7ec2c2ee044588951c..189025a711b89537022a99ec72d19eaf98e63c91 100644 --- a/fileTransfer/store/received.go +++ b/fileTransfer/store/received.go @@ -100,7 +100,7 @@ func (r *Received) AddTransfer(key *ftCrypto.TransferKey, _, exists := r.transfers[*tid] if exists { - return nil, errors.Errorf(errAddExistingReceivedTransfer, *tid) + return nil, errors.Errorf(errAddExistingReceivedTransfer, tid) } rt, err := newReceivedTransfer( diff --git a/fileTransfer/store/received_test.go b/fileTransfer/store/received_test.go index 3bcba24b6e32847945ce6d10961517aa14dded3a..11d34d143c76e42507e1b8c709a9a7e96140ea4f 100644 --- a/fileTransfer/store/received_test.go +++ b/fileTransfer/store/received_test.go @@ -122,13 +122,13 @@ func TestReceived_AddTransfer(t *testing.T) { // Tests that Received.AddTransfer returns an error when adding a transfer ID // that already exists. func TestReceived_AddTransfer_TransferAlreadyExists(t *testing.T) { - tid := ftCrypto.TransferID{0} + tid := &ftCrypto.TransferID{0} r := &Received{ - transfers: map[ftCrypto.TransferID]*ReceivedTransfer{tid: nil}, + transfers: map[ftCrypto.TransferID]*ReceivedTransfer{*tid: nil}, } expectedErr := fmt.Sprintf(errAddExistingReceivedTransfer, tid) - _, err := r.AddTransfer(nil, &tid, "", nil, 0, 0, 0) + _, err := r.AddTransfer(nil, tid, "", nil, 0, 0, 0) if err == nil || err.Error() != expectedErr { t.Errorf("Received unexpected error when adding transfer that already "+ "exists.\nexpected: %s\nreceived: %+v", expectedErr, err) diff --git a/fileTransfer/store/sent.go b/fileTransfer/store/sent.go index d5e22ad8e976bb7d21c7e5e0c100496c19b363b3..a7f89a598dd79ec14b421b0101d0dae5ab7e05cf 100644 --- a/fileTransfer/store/sent.go +++ b/fileTransfer/store/sent.go @@ -108,7 +108,7 @@ func (s *Sent) AddTransfer(recipient *id.ID, key *ftCrypto.TransferKey, _, exists := s.transfers[*tid] if exists { - return nil, errors.Errorf(errAddExistingSentTransfer, *tid) + return nil, errors.Errorf(errAddExistingSentTransfer, tid) } st, err := newSentTransfer( diff --git a/fileTransfer/store/sent_test.go b/fileTransfer/store/sent_test.go index f3f24e43e4670b3d317d43d3e88a6c21c2ae4ace..f397569ee119526b5536a82f8c4d3efbd0d024ab 100644 --- a/fileTransfer/store/sent_test.go +++ b/fileTransfer/store/sent_test.go @@ -141,13 +141,13 @@ func TestSent_AddTransfer(t *testing.T) { // Tests that Sent.AddTransfer returns an error when adding a transfer ID that // already exists. func TestSent_AddTransfer_TransferAlreadyExists(t *testing.T) { - tid := ftCrypto.TransferID{0} + tid := &ftCrypto.TransferID{0} s := &Sent{ - transfers: map[ftCrypto.TransferID]*SentTransfer{tid: nil}, + transfers: map[ftCrypto.TransferID]*SentTransfer{*tid: nil}, } expectedErr := fmt.Sprintf(errAddExistingSentTransfer, tid) - _, err := s.AddTransfer(nil, nil, &tid, "", 0, nil, 0) + _, err := s.AddTransfer(nil, nil, tid, "", 0, nil, 0) if err == nil || err.Error() != expectedErr { t.Errorf("Received unexpected error when adding transfer that already "+ "exists.\nexpected: %s\nreceived: %+v", expectedErr, err) diff --git a/fileTransfer/utils_test.go b/fileTransfer/utils_test.go index a885e4d82139d363ebce7db8051325e642de2220..daba7a06489ec8dac51f9a016d304f779ae94ec8 100644 --- a/fileTransfer/utils_test.go +++ b/fileTransfer/utils_test.go @@ -193,12 +193,10 @@ func (m *mockCmix) SendWithAssembler(*id.ID, cmix.MessageAssembler, panic("implement me") } -func (m *mockCmix) AddIdentity(*id.ID, time.Time, bool) { panic("implement me") } -func (m *mockCmix) AddIdentityWithHistory(id *id.ID, validUntil, beginning time.Time, persistent bool) { - panic("implement me") -} -func (m *mockCmix) RemoveIdentity(*id.ID) { panic("implement me") } -func (m *mockCmix) GetIdentity(*id.ID) (identity.TrackedID, error) { panic("implement me") } +func (m *mockCmix) AddIdentity(*id.ID, time.Time, bool) { panic("implement me") } +func (m *mockCmix) AddIdentityWithHistory(*id.ID, time.Time, time.Time, bool) { panic("implement me") } +func (m *mockCmix) RemoveIdentity(*id.ID) { panic("implement me") } +func (m *mockCmix) GetIdentity(*id.ID) (identity.TrackedID, error) { panic("implement me") } func (m *mockCmix) AddFingerprint(_ *id.ID, fp format.Fingerprint, mp message.Processor) error { m.handler.Lock()