From dab666dd7d4b1b866ff5896c256e2ec6f9cbd490 Mon Sep 17 00:00:00 2001 From: jbhusson <jonah@elixxir.io> Date: Wed, 1 Sep 2021 12:27:37 -0400 Subject: [PATCH] remove comment, fix generateIdentities test --- network/ephemeral/tracker.go | 5 +---- network/ephemeral/tracker_test.go | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/network/ephemeral/tracker.go b/network/ephemeral/tracker.go index dc094afb2..b3265afe1 100644 --- a/network/ephemeral/tracker.go +++ b/network/ephemeral/tracker.go @@ -141,16 +141,13 @@ func generateIdentities(protoIds []ephemeral.ProtoIdentity, ourId *id.ID, // Add identities for every ephemeral ID for i, eid := range protoIds { // Expand the grace period for both start and end - // This does not actually modify anything.... time is not a pointer and even if it were this returns the new value??? - // eid.End.Add(validityGracePeriod) - // eid.Start.Add(-validityGracePeriod) identities[i] = reception.Identity{ EphId: eid.Id, Source: ourId, AddressSize: addressSize, End: eid.End, StartValid: eid.Start.Add(-validityGracePeriod), - EndValid: eid.End.Add(validityGracePeriod), // What is this vs end? should it be modified?? + EndValid: eid.End.Add(validityGracePeriod), Ephemeral: false, } diff --git a/network/ephemeral/tracker_test.go b/network/ephemeral/tracker_test.go index 7e5cd8887..47b8f0347 100644 --- a/network/ephemeral/tracker_test.go +++ b/network/ephemeral/tracker_test.go @@ -131,7 +131,7 @@ func TestGenerateIdentities(t *testing.T) { } protoIds := []ephemeral.ProtoIdentity{{eid, s, e}} generated := generateIdentities(protoIds, id.NewIdFromString("escaline", id.Node, t), 16) - if generated[0].End != protoIds[0].End.Add(5*time.Minute) { + if generated[0].EndValid != protoIds[0].End.Add(5*time.Minute) { t.Errorf("End was not modified. Orig %+v, Generated %+v", protoIds[0].End, generated[0].End) } if generated[0].StartValid != protoIds[0].Start.Add(-5*time.Minute) { -- GitLab