From e4bd47a3f1d4ac55bc5a5464082c0eb50e7be126 Mon Sep 17 00:00:00 2001 From: "Richard T. Carback III" <rick.carback@gmail.com> Date: Thu, 21 Jul 2022 13:47:05 +0000 Subject: [PATCH] Do not print private keys to logs. It has no debugging value and it compromises security when users share their logs. We need the public keys anwyay to compare across logs. --- e2e/ratchet/ratchet.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/e2e/ratchet/ratchet.go b/e2e/ratchet/ratchet.go index aa5fd2c18..9995ba4eb 100644 --- a/e2e/ratchet/ratchet.go +++ b/e2e/ratchet/ratchet.go @@ -104,10 +104,11 @@ func (r *Ratchet) AddPartner(partnerID *id.ID, myID := r.myID - jww.INFO.Printf("Adding Partner %s:\n\tMy Private Key: %s"+ + myPubKey := diffieHellman.GeneratePublicKey(myPrivKey, r.grp) + jww.INFO.Printf("Adding Partner %s:\n\tMy Public Key: %s"+ "\n\tPartner Public Key: %s to %s", partnerID, - myPrivKey.TextVerbose(16, 0), + myPubKey.TextVerbose(16, 0), partnerPubKey.TextVerbose(16, 0), myID) mid := *partnerID -- GitLab