built the system to sequentually pick up old ephemerals, breaks interfaces and tests

cmix/identity/tracker.go

@@ -44,6 +44,8 @@ const (
 	// on receptionID.Identity.
 	DefaultExtraChecks = 5
 
+	// NetworkRetention is how long messages are
+	// retained on the network
 	NetworkRetention = 500 * time.Hour
 )
 
@@ -357,6 +359,7 @@ func (t *manager) generateIdentitiesOverRange(inQuestion *TrackedID,
 
 	// Add identities for every address ID
 	lastIdentityEnd := time.Time{}
+	var NewestIdentity receptionID.Identity
 	for i, _ := range protoIds {
 		eid := protoIds[i]
 		// Expand the grace period for both start and end
@@ -389,28 +392,23 @@ func (t *manager) generateIdentitiesOverRange(inQuestion *TrackedID,
 			identitiesToAdd = append(identitiesToAdd, newIdentity)
 		}
 
-		if isLastIdentity := i == len(protoIds)-1; isLastIdentity {
-			jww.INFO.Printf("Current Identity: %d (source: %s), Start: %s, "+
-				"End: %s, addrSize: %d",
-				newIdentity.EphId.Int64(),
-				newIdentity.Source,
-				newIdentity.StartValid,
-				newIdentity.EndValid,
-				addressSize)
+		if newIdentity.End.After(lastIdentityEnd) {
 			lastIdentityEnd = newIdentity.End
+			NewestIdentity = newIdentity
 		}
 	}
 
 	//link the chain
 	if len(identitiesToChain) > 0 {
-		firstLink := identitiesToChain[len(identitiesToChain)-1]
+		firstLink := &identitiesToChain[len(identitiesToChain)-1]
 		currentLink := firstLink
 		if len(identitiesToChain) > 1 {
 			for i := len(identitiesToChain) - 1; i >= 0; i-- {
 				currentLink.ProcessNext = &identitiesToChain[i]
+				currentLink = currentLink.ProcessNext
 			}
 		}
-		identitiesToAdd = append(identitiesToAdd, firstLink)
+		identitiesToAdd = append(identitiesToAdd, *firstLink)
 	}
 
 	//add the identities
@@ -420,8 +418,16 @@ func (t *manager) generateIdentitiesOverRange(inQuestion *TrackedID,
 		}
 	}
 
+	jww.INFO.Printf("Current Identity: %d (source: %s), Start: %s, "+
+		"End: %s, addrSize: %d",
+		NewestIdentity.EphId.Int64(),
+		NewestIdentity.Source,
+		NewestIdentity.StartValid,
+		NewestIdentity.EndValid,
+		addressSize)
+
 	jww.INFO.Printf("Number of identities generated: %d", len(protoIds))
-	return lastIdentityEnd
+	return NewestIdentity.End
 }
 
 // save persistent TrackedID to storage