From 014027c212dc7def0beb6a3c8f18c622a0f19bea Mon Sep 17 00:00:00 2001
From: Dariusz Rybicki <dariusz@elixxir.io>
Date: Tue, 30 Aug 2022 12:30:11 +0100
Subject: [PATCH] Remove unused JSON helper function
convertJsonNumberToString(in:minNumberLength:)
---
Sources/XXClient/Helpers/JSONHelpers.swift | 18 -------
.../Helpers/JSONHelpersTests.swift | 51 -------------------
2 files changed, 69 deletions(-)
diff --git a/Sources/XXClient/Helpers/JSONHelpers.swift b/Sources/XXClient/Helpers/JSONHelpers.swift
index 5653752d..eb719ec9 100644
--- a/Sources/XXClient/Helpers/JSONHelpers.swift
+++ b/Sources/XXClient/Helpers/JSONHelpers.swift
@@ -18,24 +18,6 @@ func convertJsonNumberToString(
return output
}
-func convertJsonNumberToString(
- in input: Data,
- minNumberLength: Int
-) -> Data {
- guard var string = String(data: input, encoding: .utf8) else {
- return input
- }
- string = string.replacingOccurrences(
- of: #":( *)([0-9]{\#(minNumberLength),})( *)(,*)"#,
- with: #":$1"$2"$3$4"#,
- options: [.regularExpression]
- )
- guard let output = string.data(using: .utf8) else {
- return input
- }
- return output
-}
-
func convertJsonStringToNumber(
in input: Data,
at key: String
diff --git a/Tests/XXClientTests/Helpers/JSONHelpersTests.swift b/Tests/XXClientTests/Helpers/JSONHelpersTests.swift
index 20a90116..2ebe8530 100644
--- a/Tests/XXClientTests/Helpers/JSONHelpersTests.swift
+++ b/Tests/XXClientTests/Helpers/JSONHelpersTests.swift
@@ -61,36 +61,6 @@ final class JSONHelpersTests: XCTestCase {
)
}
- func testConvertingNumberToStringByLength() {
- assertConvertingJsonNumberToString(
- input: """
- {
- "text": "hello",
- "number1": 123456789,
- "number2": 1234567890,
- "number3": 123456789,
- "number4": 1234567890
- }
- """,
- minNumberLength: 10,
- expected: """
- {
- "text": "hello",
- "number1": 123456789,
- "number2": "1234567890",
- "number3": 123456789,
- "number4": "1234567890"
- }
- """
- )
-
- assertConvertingJsonNumberToString(
- input: #"{"text":"hello","number1":123456789,"number2":1234567890,"number3":123456789,"number4":1234567890}"#,
- minNumberLength: 10,
- expected: #"{"text":"hello","number1":123456789,"number2":"1234567890","number3":123456789,"number4":"1234567890"}"#
- )
- }
-
func testConvertingStringToNumber() {
assertConvertingJsonStringToNumber(
input: #"{"number":"1234567890","text":"hello"}"#,
@@ -171,27 +141,6 @@ private func assertConvertingJsonNumberToString(
)
}
-private func assertConvertingJsonNumberToString(
- input: String,
- minNumberLength: Int,
- expected: String,
- file: StaticString = #file,
- line: UInt = #line
-) {
- XCTAssertNoDifference(
- String(
- data: convertJsonNumberToString(
- in: input.data(using: .utf8)!,
- minNumberLength: minNumberLength
- ),
- encoding: .utf8
- )!,
- expected,
- file: file,
- line: line
- )
-}
-
private func assertConvertingJsonStringToNumber(
input: String,
key: String,
--
GitLab