diff --git a/Sources/XXMessengerClient/Messenger/Functions/MessengerCreate.swift b/Sources/XXMessengerClient/Messenger/Functions/MessengerCreate.swift index ed9d193d3592a10dd19a5a5d68d81576cb422f71..bee7f47245c6ebaabd1f615b63881abd6437fddc 100644 --- a/Sources/XXMessengerClient/Messenger/Functions/MessengerCreate.swift +++ b/Sources/XXMessengerClient/Messenger/Functions/MessengerCreate.swift @@ -16,7 +16,7 @@ extension MessengerCreate { let password = env.generateSecret() try env.passwordStorage.save(password) let storageDir = env.storageDir - try env.fileManager.removeDirectory(storageDir) + try env.fileManager.removeItem(storageDir) try env.fileManager.createDirectory(storageDir) try env.newCMix( ndfJSON: String(data: ndfData, encoding: .utf8)!, diff --git a/Sources/XXMessengerClient/Messenger/Functions/MessengerDestroy.swift b/Sources/XXMessengerClient/Messenger/Functions/MessengerDestroy.swift index 7d6932badafbae5128694b414df70a32c405fd02..89c472ce7c10a142cd49b559ff149af11997d09b 100644 --- a/Sources/XXMessengerClient/Messenger/Functions/MessengerDestroy.swift +++ b/Sources/XXMessengerClient/Messenger/Functions/MessengerDestroy.swift @@ -23,7 +23,7 @@ extension MessengerDestroy { env.e2e.set(nil) env.cMix.set(nil) env.isListeningForMessages.set(false) - try env.fileManager.removeDirectory(env.storageDir) + try env.fileManager.removeItem(env.storageDir) try env.passwordStorage.remove() } } diff --git a/Sources/XXMessengerClient/Messenger/Functions/MessengerRestoreBackup.swift b/Sources/XXMessengerClient/Messenger/Functions/MessengerRestoreBackup.swift index b196faca4b578bf3ea9bc534073be015b24dc816..e1f0ec10df6df4a601153cc4ecc6e8c80cb0419c 100644 --- a/Sources/XXMessengerClient/Messenger/Functions/MessengerRestoreBackup.swift +++ b/Sources/XXMessengerClient/Messenger/Functions/MessengerRestoreBackup.swift @@ -33,7 +33,7 @@ extension MessengerRestoreBackup { let ndfData = try env.downloadNDF(env.ndfEnvironment) let password = env.generateSecret() try env.passwordStorage.save(password) - try env.fileManager.removeDirectory(storageDir) + try env.fileManager.removeItem(storageDir) try env.fileManager.createDirectory(storageDir) let report = try env.newCMixFromBackup( ndfJSON: String(data: ndfData, encoding: .utf8)!, diff --git a/Sources/XXMessengerClient/Utils/MessengerFileManager.swift b/Sources/XXMessengerClient/Utils/MessengerFileManager.swift index 700990ea64b97c92175995ded858de7fa7486381..9e2c1590ca4c0427855da78b98bfda1b93e8028d 100644 --- a/Sources/XXMessengerClient/Utils/MessengerFileManager.swift +++ b/Sources/XXMessengerClient/Utils/MessengerFileManager.swift @@ -3,7 +3,7 @@ import XCTestDynamicOverlay public struct MessengerFileManager { public var isDirectoryEmpty: (String) -> Bool - public var removeDirectory: (String) throws -> Void + public var removeItem: (String) throws -> Void public var createDirectory: (String) throws -> Void } @@ -16,7 +16,7 @@ extension MessengerFileManager { let contents = try? fileManager.contentsOfDirectory(atPath: path) return contents?.isEmpty ?? true }, - removeDirectory: { path in + removeItem: { path in if fileManager.fileExists(atPath: path) { try fileManager.removeItem(atPath: path) } @@ -34,7 +34,7 @@ extension MessengerFileManager { extension MessengerFileManager { public static let unimplemented = MessengerFileManager( isDirectoryEmpty: XCTUnimplemented("\(Self.self).isDirectoryEmpty", placeholder: false), - removeDirectory: XCTUnimplemented("\(Self.self).removeDirectory"), + removeItem: XCTUnimplemented("\(Self.self).removeItem"), createDirectory: XCTUnimplemented("\(Self.self).createDirectory") ) } diff --git a/Tests/XXMessengerClientTests/Messenger/Functions/MessengerCreateTests.swift b/Tests/XXMessengerClientTests/Messenger/Functions/MessengerCreateTests.swift index 2180dda3db578b74a892b2166e66a9beb20357dd..0c8ce3bab33f2923976b113098da9c124c9cc2bf 100644 --- a/Tests/XXMessengerClientTests/Messenger/Functions/MessengerCreateTests.swift +++ b/Tests/XXMessengerClientTests/Messenger/Functions/MessengerCreateTests.swift @@ -15,7 +15,7 @@ final class MessengerCreateTests: XCTestCase { var didDownloadNDF: [NDFEnvironment] = [] var didGenerateSecret: [Int] = [] var didSavePassword: [Data] = [] - var didRemoveDirectory: [String] = [] + var didRemoveItem: [String] = [] var didCreateDirectory: [String] = [] var didNewCMix: [DidNewCMix] = [] @@ -37,8 +37,8 @@ final class MessengerCreateTests: XCTestCase { didSavePassword.append(password) } env.storageDir = storageDir - env.fileManager.removeDirectory = { path in - didRemoveDirectory.append(path) + env.fileManager.removeItem = { path in + didRemoveItem.append(path) } env.fileManager.createDirectory = { path in didCreateDirectory.append(path) @@ -58,7 +58,7 @@ final class MessengerCreateTests: XCTestCase { XCTAssertNoDifference(didDownloadNDF, [.unimplemented]) XCTAssertNoDifference(didGenerateSecret, [32]) XCTAssertNoDifference(didSavePassword, [password]) - XCTAssertNoDifference(didRemoveDirectory, [storageDir]) + XCTAssertNoDifference(didRemoveItem, [storageDir]) XCTAssertNoDifference(didCreateDirectory, [storageDir]) XCTAssertNoDifference(didNewCMix, [.init( ndfJSON: String(data: ndf, encoding: .utf8)!, @@ -108,7 +108,7 @@ final class MessengerCreateTests: XCTestCase { env.generateSecret.run = { _ in "password".data(using: .utf8)! } env.passwordStorage.save = { _ in } env.storageDir = "storage-dir" - env.fileManager.removeDirectory = { _ in throw error } + env.fileManager.removeItem = { _ in throw error } let create: MessengerCreate = .live(env) XCTAssertThrowsError(try create()) { err in @@ -126,7 +126,7 @@ final class MessengerCreateTests: XCTestCase { env.generateSecret.run = { _ in "password".data(using: .utf8)! } env.passwordStorage.save = { _ in } env.storageDir = "storage-dir" - env.fileManager.removeDirectory = { _ in } + env.fileManager.removeItem = { _ in } env.fileManager.createDirectory = { _ in throw error } let create: MessengerCreate = .live(env) @@ -145,7 +145,7 @@ final class MessengerCreateTests: XCTestCase { env.generateSecret.run = { _ in "password".data(using: .utf8)! } env.passwordStorage.save = { _ in } env.storageDir = "storage-dir" - env.fileManager.removeDirectory = { _ in } + env.fileManager.removeItem = { _ in } env.fileManager.createDirectory = { _ in } env.newCMix.run = { _, _, _, _ in throw error } let create: MessengerCreate = .live(env) diff --git a/Tests/XXMessengerClientTests/Messenger/Functions/MessengerDestroyTests.swift b/Tests/XXMessengerClientTests/Messenger/Functions/MessengerDestroyTests.swift index ccf999e77e6771724d17e27b6b43ce6a811fb8ae..99a52e8402ac9c93e71988adaf99610f21b1cb95 100644 --- a/Tests/XXMessengerClientTests/Messenger/Functions/MessengerDestroyTests.swift +++ b/Tests/XXMessengerClientTests/Messenger/Functions/MessengerDestroyTests.swift @@ -9,7 +9,7 @@ final class MessengerDestroyTests: XCTestCase { var hasRunningProcesses: [Bool] = [true, true, false] var didStopNetworkFollower = 0 var didSleep: [TimeInterval] = [] - var didRemoveDirectory: [String] = [] + var didRemoveItem: [String] = [] var didSetUD: [UserDiscovery?] = [] var didSetE2E: [E2E?] = [] var didSetCMix: [CMix?] = [] @@ -30,7 +30,7 @@ final class MessengerDestroyTests: XCTestCase { env.e2e.set = { didSetE2E.append($0) } env.cMix.set = { didSetCMix.append($0) } env.isListeningForMessages.set = { didSetIsListeningForMessages.append($0) } - env.fileManager.removeDirectory = { didRemoveDirectory.append($0) } + env.fileManager.removeItem = { didRemoveItem.append($0) } env.passwordStorage.remove = { didRemovePassword += 1 } let destroy: MessengerDestroy = .live(env) @@ -42,7 +42,7 @@ final class MessengerDestroyTests: XCTestCase { XCTAssertNoDifference(didSetE2E.map { $0 == nil }, [true]) XCTAssertNoDifference(didSetCMix.map { $0 == nil }, [true]) XCTAssertNoDifference(didSetIsListeningForMessages, [false]) - XCTAssertNoDifference(didRemoveDirectory, [storageDir]) + XCTAssertNoDifference(didRemoveItem, [storageDir]) XCTAssertNoDifference(didRemovePassword, 1) } @@ -78,7 +78,7 @@ final class MessengerDestroyTests: XCTestCase { env.e2e.set = { didSetE2E.append($0) } env.cMix.set = { didSetCMix.append($0) } env.isListeningForMessages.set = { didSetIsListeningForMessages.append($0) } - env.fileManager.removeDirectory = { _ in throw error } + env.fileManager.removeItem = { _ in throw error } let destroy: MessengerDestroy = .live(env) XCTAssertThrowsError(try destroy()) { err in @@ -94,7 +94,7 @@ final class MessengerDestroyTests: XCTestCase { struct Error: Swift.Error, Equatable {} let error = Error() let storageDir = "test-storage-dir" - var didRemoveDirectory: [String] = [] + var didRemoveItem: [String] = [] var didSetUD: [UserDiscovery?] = [] var didSetE2E: [E2E?] = [] var didSetCMix: [CMix?] = [] @@ -107,7 +107,7 @@ final class MessengerDestroyTests: XCTestCase { env.cMix.set = { didSetCMix.append($0) } env.isListeningForMessages.set = { didSetIsListeningForMessages.append($0) } env.storageDir = storageDir - env.fileManager.removeDirectory = { didRemoveDirectory.append($0) } + env.fileManager.removeItem = { didRemoveItem.append($0) } env.passwordStorage.remove = { throw error } let destroy: MessengerDestroy = .live(env) @@ -118,6 +118,6 @@ final class MessengerDestroyTests: XCTestCase { XCTAssertNoDifference(didSetE2E.map { $0 == nil }, [true]) XCTAssertNoDifference(didSetCMix.map { $0 == nil }, [true]) XCTAssertNoDifference(didSetIsListeningForMessages, [false]) - XCTAssertNoDifference(didRemoveDirectory, [storageDir]) + XCTAssertNoDifference(didRemoveItem, [storageDir]) } } diff --git a/Tests/XXMessengerClientTests/Messenger/Functions/MessengerRestoreBackupTests.swift b/Tests/XXMessengerClientTests/Messenger/Functions/MessengerRestoreBackupTests.swift index 672adc37550225bdab6a9ea7953c2b5a0b86b248..7e55ddc330cda16e776b36db8abc796e24b9a3d4 100644 --- a/Tests/XXMessengerClientTests/Messenger/Functions/MessengerRestoreBackupTests.swift +++ b/Tests/XXMessengerClientTests/Messenger/Functions/MessengerRestoreBackupTests.swift @@ -40,7 +40,7 @@ final class MessengerRestoreBackupTests: XCTestCase { env.generateSecret.run = { _ in password } env.passwordStorage.save = { caughtActions.append(.didSavePassword(password: $0)) } env.passwordStorage.load = { password } - env.fileManager.removeDirectory = { caughtActions.append(.didRemoveDirectory(path: $0)) } + env.fileManager.removeItem = { caughtActions.append(.didRemoveItem(path: $0)) } env.fileManager.createDirectory = { caughtActions.append(.didCreateDirectory(path: $0)) } env.newCMixFromBackup.run = { ndfJSON, storageDir, backupPassphrase, sessionPassword, backupFileContents in @@ -114,7 +114,7 @@ final class MessengerRestoreBackupTests: XCTestCase { .didSavePassword( password: password ), - .didRemoveDirectory( + .didRemoveItem( path: env.storageDir ), .didCreateDirectory( @@ -185,7 +185,7 @@ private enum CaughtAction: Equatable { case didSavePassword( password: Data ) - case didRemoveDirectory( + case didRemoveItem( path: String ) case didCreateDirectory(