Remove truncate and add on conflict clause instead

scheduling.py

@@ -73,7 +73,7 @@ def main():
         current_chain_conf = {}
         init_auth = get_authorizer_nodes(auth_conn)
         for i in init_auth:
-            auth_nids.add(i[0])
+            auth_nids.add(bytes(i[0]))
         while True:
             try:
                 log.info("Polling substrate...")
@@ -104,13 +104,14 @@ def main():
                     to_add = new_auth_set.difference(auth_nids)
                     to_delete = auth_nids.difference(new_auth_set)
                     to_revoke = set_authorizer_nodes(auth_conn, to_add, to_delete)
+                    log.info(f"To revoke: {to_revoke}")  # TODO: remove me
                     auth_nids = new_auth_set
                     revoke_auth(to_revoke)
 
                     # Pass a copy because the dict will be mutated
                     set_active_nodes(conn, copy.deepcopy(new_dict))
 
-                    # Update the new dictionary of active nodes
+                    #
                     active_dict = new_dict
 
                 time.sleep(polling_freq)
@@ -229,15 +230,13 @@ def revoke_auth(to_revoke):
     :param to_revoke: list of node IP addresses
     """
     log.info(f"Revoking access to {len(to_revoke)} nodes...")
-    for nid in to_revoke:
-        cmd = f"sudo nft -a list chain inet filter input | grep '{nid}' | awk -F'handle ' '{{print $2}}' | xargs -Ixxx sudo nft delete rule inet filter input handle xxx"
-        log.debug(cmd)
-        p = subprocess.Popen(cmd.split())
-        output, error = p.communicate()
-        if output:
-            log.debug(output)
-        if error:
-            raise IOError(error)
+    for node_ip in to_revoke:
+        cmd = f"sudo nft -a list chain inet filter input | grep '{node_ip}' | awk -F'handle ' '{{print $2}}' | xargs -Ixxx sudo nft delete rule inet filter input handle xxx"
+        log.info(f"Running revoke command: {cmd}")
+        p = subprocess.Popen(['/bin/bash', '-c', cmd])
+        p.wait(5)
+        if p.returncode != 0:
+            raise OSError(f"Revoke command exited with return code {p.returncode}")
 
 
 def id_to_reg_code(cmix_id):
@@ -708,33 +707,39 @@ def set_authorizer_nodes(conn, to_add, to_delete):
 
     # Convert Node information into authorizer insert command
     node_list = get_authorizer_nodes(conn)
+    log.info(f"Current authorizer nodes: {node_list}")  # TODO: remove me
     to_revoke = []
 
     delete_command = "DELETE FROM nodes WHERE id = %s;"
     for row in node_list:
-        if row[0] in to_delete:
+        if bytes(row[0]) in to_delete:
+            log.info(f"Deleting {row[0]} [{row[1]}] - last updated in DB at {row[2]}")  # TODO: remove me
             try:
                 cur.execute(delete_command, (row[0],))
                 log.debug(cur.query)
             except Exception as e:
                 log.error(f"Failed to remove node from authorizer DB: {cur.query}")
+                cur.close()
                 raise e
-            to_revoke.append(row[1])
+            if row[1]:
+                to_revoke.append(row[1])
+
+    if len(to_add) > 0:
+        insert_list = [(i, None, None) for i in to_add]
+        # Insert Node information into authorizer db
+        insert_command = "INSERT INTO nodes (id, ip_address, last_updated) VALUES" + \
+            (' (%s, %s, %s),' * len(insert_list))
+        insert_command = insert_command[:-1] + " ON CONFLICT DO NOTHING;"
+        try:
+            cur.execute(insert_command, [e for l in insert_list for e in l])
+            log.debug(cur.query)
+        except Exception as e:
+            log.error(f"Failed to insert into authorizer db: {cur.query}")
+            cur.close()
+            raise e
 
-    insert_list = [(i, None, None) for i in to_add]
-    # Insert Node information into authorizer db
-    insert_command = "INSERT INTO nodes (id, ip_address, last_updated) VALUES" + \
-                     (' (%s, %s, %s),' * len(insert_list))
-    insert_command = insert_command[:-1] + " ON CONFLICT DO NOTHING;"
-    try:
-        cur.execute(insert_command, [e for l in insert_list for e in l])
-        log.debug(cur.query)
-        conn.commit()
-    except Exception as e:
-        log.error(f"Failed to insert into authorizer db: {cur.query}")
-        raise e
-    finally:
-        cur.close()
+    conn.commit()
+    cur.close()
     return to_revoke