Skip to content
Snippets Groups Projects
Commit 22a21b47 authored by Josh Brooks's avatar Josh Brooks
Browse files

Fix mistmatched versions

parent 337257e0
No related branches found
No related tags found
3 merge requests!510Release,!364Modify KV.Set to no longer contain version parameter,!354Channels impl
......@@ -24,8 +24,6 @@ import (
"google.golang.org/protobuf/proto"
)
const currentMeteredCmixMessageVersion = 0
type meteredCmixMessageHandler struct{}
type meteredCmixMessage struct {
......@@ -49,7 +47,7 @@ func (*meteredCmixMessageHandler) SaveMessage(kv *versioned.KV, m interface{},
// Create versioned object
obj := versioned.Object{
Version: currentMeteredCmixMessageVersion,
Version: utility.CurrentMessageBufferVersion,
Timestamp: netTime.Now(),
Data: marshaled,
}
......@@ -57,7 +55,7 @@ func (*meteredCmixMessageHandler) SaveMessage(kv *versioned.KV, m interface{},
// Save versioned object
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
return kv.Set(key, utility.CurrentMessageBufferVersion, &obj)
return kv.Set(key, &obj)
}
// LoadMessage returns the message with the specified key from the key value
......@@ -66,7 +64,7 @@ func (*meteredCmixMessageHandler) SaveMessage(kv *versioned.KV, m interface{},
func (*meteredCmixMessageHandler) LoadMessage(kv *versioned.KV, key string) (
interface{}, error) {
// Load the versioned object
vo, err := kv.Get(key, currentMeteredCmixMessageVersion)
vo, err := kv.Get(key, utility.CurrentMessageBufferVersion)
if err != nil {
return nil, err
}
......@@ -85,7 +83,7 @@ func (*meteredCmixMessageHandler) LoadMessage(kv *versioned.KV, key string) (
// DeleteMessage deletes the message with the specified key from the key value
// store.
func (*meteredCmixMessageHandler) DeleteMessage(kv *versioned.KV, key string) error {
return kv.Delete(key, currentMeteredCmixMessageVersion)
return kv.Delete(key, utility.CurrentMessageBufferVersion)
}
// HashMessage generates a hash of the message.
......
......@@ -67,14 +67,14 @@ func (r *registrar) save() error {
}
obj := versioned.Object{
Version: currentStoreVersion,
Version: currentKeyVersion,
Timestamp: now,
Data: data,
}
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
return r.kv.Set(storeKey, currentKeyVersion, &obj)
return r.kv.Set(storeKey, &obj)
}
// marshal builds a byte representation of the registrar.
......
......@@ -30,13 +30,13 @@ func savePart(kv *versioned.KV, partNum uint8, part []byte) error {
key := makeMultiPartMessagePartKey(partNum)
obj := versioned.Object{
Version: currentMultiPartMessagePartVersion,
Version: currentMultiPartMessageVersion,
Timestamp: netTime.Now(),
Data: part,
}
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
return kv.Set(key, currentMultiPartMessageVersion, &obj)
return kv.Set(key, &obj)
}
func deletePart(kv *versioned.KV, partNum uint8) error {
......
......@@ -40,15 +40,14 @@ func makeRelationshipFingerprint(t session2.RelationshipType, grp *cyclic.Group,
func storeRelationshipFingerprint(fp []byte, kv *versioned.KV) error {
now := netTime.Now()
obj := versioned.Object{
Version: currentRelationshipFingerprintVersion,
Version: currentRelationshipVersion,
Timestamp: now,
Data: fp,
}
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
return kv.Set(relationshipFingerprintKey, currentRelationshipVersion,
&obj)
return kv.Set(relationshipFingerprintKey, &obj)
}
func loadRelationshipFingerprint(kv *versioned.KV) []byte {
......
......@@ -146,15 +146,14 @@ func (u *User) SetRegistrationTimestamp(tsNano int64) {
binary.BigEndian.PutUint64(tsBytes, uint64(tsNano))
obj := &versioned.Object{
Version: currentRegValidationSigVersion,
Version: registrationTimestampVersion,
Timestamp: netTime.Now(),
Data: tsBytes,
}
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
err := u.kv.Set(registrationTimestampKey,
registrationTimestampVersion, obj)
err := u.kv.Set(registrationTimestampKey, obj)
if err != nil {
jww.FATAL.Panicf("Failed to store the reception timestamp: %s", err)
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment