Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
client
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
elixxir
client
Commits
4ce3e79b
Commit
4ce3e79b
authored
Jun 15, 2022
by
Jono Wenger
Browse files
Options
Downloads
Patches
Plain Diff
Fix file transfer e2e wrapper listener registration (used my ID instead of zero user)
parent
992c6f14
No related branches found
No related tags found
1 merge request
!510
Release
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
catalog/messageTypes.go
+2
-2
2 additions, 2 deletions
catalog/messageTypes.go
fileTransfer2/e2e/utils_test.go
+5
-10
5 additions, 10 deletions
fileTransfer2/e2e/utils_test.go
fileTransfer2/e2e/wrapper.go
+1
-1
1 addition, 1 deletion
fileTransfer2/e2e/wrapper.go
with
8 additions
and
13 deletions
catalog/messageTypes.go
+
2
−
2
View file @
4ce3e79b
...
@@ -39,11 +39,11 @@ const (
...
@@ -39,11 +39,11 @@ const (
// NewFileTransfer is transmitted first on the initialization of a file
// NewFileTransfer is transmitted first on the initialization of a file
// transfer to inform the receiver about the incoming file.
// transfer to inform the receiver about the incoming file.
NewFileTransfer
=
50
NewFileTransfer
MessageType
=
50
// EndFileTransfer is sent once all file parts have been transmitted to
// EndFileTransfer is sent once all file parts have been transmitted to
// inform the receiver that the file transfer has ended.
// inform the receiver that the file transfer has ended.
EndFileTransfer
=
51
EndFileTransfer
MessageType
=
51
// ConnectionAuthenticationRequest is sent by the recipient
// ConnectionAuthenticationRequest is sent by the recipient
// of an authenticated connection request
// of an authenticated connection request
...
...
This diff is collapsed.
Click to expand it.
fileTransfer2/e2e/utils_test.go
+
5
−
10
View file @
4ce3e79b
...
@@ -148,13 +148,13 @@ func (l *mockListener) Name() string {
...
@@ -148,13 +148,13 @@ func (l *mockListener) Name() string {
type
mockE2eHandler
struct
{
type
mockE2eHandler
struct
{
msgMap
map
[
id
.
ID
]
map
[
catalog
.
MessageType
][][]
byte
msgMap
map
[
id
.
ID
]
map
[
catalog
.
MessageType
][][]
byte
listeners
map
[
id
.
ID
]
map
[
catalog
.
MessageType
]
receive
.
Listener
listeners
map
[
catalog
.
MessageType
]
receive
.
Listener
}
}
func
newMockE2eHandler
()
*
mockE2eHandler
{
func
newMockE2eHandler
()
*
mockE2eHandler
{
return
&
mockE2eHandler
{
return
&
mockE2eHandler
{
msgMap
:
make
(
map
[
id
.
ID
]
map
[
catalog
.
MessageType
][][]
byte
),
msgMap
:
make
(
map
[
id
.
ID
]
map
[
catalog
.
MessageType
][][]
byte
),
listeners
:
make
(
map
[
id
.
ID
]
map
[
catalog
.
MessageType
]
receive
.
Listener
),
listeners
:
make
(
map
[
catalog
.
MessageType
]
receive
.
Listener
),
}
}
}
}
...
@@ -178,7 +178,7 @@ func newMockE2e(myID *id.ID, handler *mockE2eHandler) *mockE2e {
...
@@ -178,7 +178,7 @@ func newMockE2e(myID *id.ID, handler *mockE2eHandler) *mockE2e {
func
(
m
*
mockE2e
)
SendE2E
(
mt
catalog
.
MessageType
,
recipient
*
id
.
ID
,
payload
[]
byte
,
func
(
m
*
mockE2e
)
SendE2E
(
mt
catalog
.
MessageType
,
recipient
*
id
.
ID
,
payload
[]
byte
,
_
e2e
.
Params
)
([]
id
.
Round
,
e2eCrypto
.
MessageID
,
time
.
Time
,
error
)
{
_
e2e
.
Params
)
([]
id
.
Round
,
e2eCrypto
.
MessageID
,
time
.
Time
,
error
)
{
m
.
handler
.
listeners
[
*
recipient
][
mt
]
.
Hear
(
receive
.
Message
{
m
.
handler
.
listeners
[
mt
]
.
Hear
(
receive
.
Message
{
MessageType
:
mt
,
MessageType
:
mt
,
Payload
:
payload
,
Payload
:
payload
,
Sender
:
m
.
myID
,
Sender
:
m
.
myID
,
...
@@ -188,14 +188,9 @@ func (m *mockE2e) SendE2E(mt catalog.MessageType, recipient *id.ID, payload []by
...
@@ -188,14 +188,9 @@ func (m *mockE2e) SendE2E(mt catalog.MessageType, recipient *id.ID, payload []by
return
[]
id
.
Round
{
42
},
e2eCrypto
.
MessageID
{},
netTime
.
Now
(),
nil
return
[]
id
.
Round
{
42
},
e2eCrypto
.
MessageID
{},
netTime
.
Now
(),
nil
}
}
func
(
m
*
mockE2e
)
RegisterListener
(
senderID
*
id
.
ID
,
mt
catalog
.
MessageType
,
func
(
m
*
mockE2e
)
RegisterListener
(
_
*
id
.
ID
,
mt
catalog
.
MessageType
,
listener
receive
.
Listener
)
receive
.
ListenerID
{
listener
receive
.
Listener
)
receive
.
ListenerID
{
if
_
,
exists
:=
m
.
handler
.
listeners
[
*
senderID
];
!
exists
{
m
.
handler
.
listeners
[
mt
]
=
listener
m
.
handler
.
listeners
[
*
senderID
]
=
map
[
catalog
.
MessageType
]
receive
.
Listener
{
mt
:
listener
}
}
else
if
_
,
exists
=
m
.
handler
.
listeners
[
*
senderID
][
mt
];
!
exists
{
m
.
handler
.
listeners
[
*
senderID
][
mt
]
=
listener
}
return
receive
.
ListenerID
{}
return
receive
.
ListenerID
{}
}
}
...
...
This diff is collapsed.
Click to expand it.
fileTransfer2/e2e/wrapper.go
+
1
−
1
View file @
4ce3e79b
...
@@ -57,7 +57,7 @@ func NewWrapper(receiveCB ft.ReceiveCallback, p Params, ft ft.FileTransfer,
...
@@ -57,7 +57,7 @@ func NewWrapper(receiveCB ft.ReceiveCallback, p Params, ft ft.FileTransfer,
}
}
// Register listener to receive new file transfers
// Register listener to receive new file transfers
w
.
e2e
.
RegisterListener
(
w
.
myID
,
catalog
.
NewFileTransfer
,
&
listener
{
w
})
w
.
e2e
.
RegisterListener
(
&
id
.
ZeroUser
,
catalog
.
NewFileTransfer
,
&
listener
{
w
})
return
w
,
nil
return
w
,
nil
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment