Comments for tests and decode/encode fix on CryptographicIdentity

storage/user/cryptographic_test.go

@@ -10,6 +10,7 @@ import (
 	"testing"
 )
 
+// Test for NewCryptographicIdentity function
 func TestNewCryptographicIdentity(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("zezima", id.User, t)
@@ -21,6 +22,7 @@ func TestNewCryptographicIdentity(t *testing.T) {
 	}
 }
 
+// Test loading cryptographic identity from KV store
 func TestLoadCryptographicIdentity(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("zezima", id.User, t)
@@ -40,6 +42,7 @@ func TestLoadCryptographicIdentity(t *testing.T) {
 	}
 }
 
+// Happy path for GetRSA function
 func TestCryptographicIdentity_GetRSA(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("zezima", id.User, t)
@@ -53,6 +56,7 @@ func TestCryptographicIdentity_GetRSA(t *testing.T) {
 	}
 }
 
+// Happy path for GetSalt function
 func TestCryptographicIdentity_GetSalt(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("zezima", id.User, t)
@@ -63,6 +67,7 @@ func TestCryptographicIdentity_GetSalt(t *testing.T) {
 	}
 }
 
+// Happy path for GetUserID function
 func TestCryptographicIdentity_GetUserID(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("zezima", id.User, t)
@@ -72,6 +77,7 @@ func TestCryptographicIdentity_GetUserID(t *testing.T) {
 	}
 }
 
+// Happy path for IsPrecanned functions
 func TestCryptographicIdentity_IsPrecanned(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("zezima", id.User, t)

storage/user/regValidationSig_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 )
 
+// Test User GetRegistrationValidationSignature function
 func TestUser_GetRegistrationValidationSignature(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("test", id.User, t)
@@ -31,6 +32,7 @@ func TestUser_GetRegistrationValidationSignature(t *testing.T) {
 	}
 }
 
+// Test SetRegistrationValidationSignature setter
 func TestUser_SetRegistrationValidationSignature(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("test", id.User, t)
@@ -56,6 +58,7 @@ func TestUser_SetRegistrationValidationSignature(t *testing.T) {
 	}
 }
 
+// Test loading registrationValidationSignature from the KV store
 func TestUser_loadRegistrationValidationSignature(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("test", id.User, t)

storage/user/user_test.go

@@ -9,6 +9,7 @@ import (
 	"testing"
 )
 
+// Test loading user from a KV store
 func TestLoadUser(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	_, err := LoadUser(kv)
@@ -30,6 +31,7 @@ func TestLoadUser(t *testing.T) {
 	}
 }
 
+// Test NewUser function
 func TestNewUser(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("test", id.User, t)
@@ -39,6 +41,7 @@ func TestNewUser(t *testing.T) {
 	}
 }
 
+// Test GetCryptographicIdentity function from user
 func TestUser_GetCryptographicIdentity(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("test", id.User, t)

storage/user/username_test.go

@@ -9,6 +9,7 @@ import (
 	"time"
 )
 
+// Test normal function and errors for User's SetUsername function
 func TestUser_SetUsername(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("test", id.User, t)
@@ -39,6 +40,7 @@ func TestUser_SetUsername(t *testing.T) {
 	}
 }
 
+// Test functionality of User's GetUsername function
 func TestUser_GetUsername(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("test", id.User, t)
@@ -63,6 +65,7 @@ func TestUser_GetUsername(t *testing.T) {
 	}
 }
 
+// Test the loadUsername helper function
 func TestUser_loadUsername(t *testing.T) {
 	kv := versioned.NewKV(make(ekv.Memstore))
 	uid := id.NewIdFromString("test", id.User, t)