Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
client
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
elixxir
client
Commits
aae656cd
Commit
aae656cd
authored
2 years ago
by
Josh Brooks
Browse files
Options
Downloads
Patches
Plain Diff
Standardize unimported interfaces in groupChat
parent
7632bacf
No related branches found
No related tags found
2 merge requests
!510
Release
,
!273
Hotfix/group chat refactor
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
groupChat/interface.go
+4
-4
4 additions, 4 deletions
groupChat/interface.go
groupChat/manager.go
+3
-3
3 additions, 3 deletions
groupChat/manager.go
groupChat/manager_test.go
+2
-2
2 additions, 2 deletions
groupChat/manager_test.go
groupChat/messenger_test.go
+3
-3
3 additions, 3 deletions
groupChat/messenger_test.go
with
12 additions
and
12 deletions
groupChat/interface.go
+
4
−
4
View file @
aae656cd
...
...
@@ -100,9 +100,9 @@ type ReceiveCallback func(msg MessageReceive)
// Sub-interfaces from other packages //////////////////////////////////////////////
////////////////////////////////////////////////////////////////////////////////////
//
messenger
is a sub-interface mocking the xxdk.E2e object.
//
groupE2e
is a sub-interface mocking the xxdk.E2e object.
// This contains methods specific for this package.
type
messenger
interface
{
type
groupE2e
interface
{
GetCmix
()
cmix
.
Client
GetE2E
()
e2e
.
Handler
GetReceptionIdentity
()
xxdk
.
ReceptionIdentity
...
...
@@ -122,9 +122,9 @@ type groupCmix interface {
GetMaxMessageLength
()
int
}
//
e
2eHandler is a subset of the e2e.Handler interface containing only the methods
//
groupE
2eHandler is a subset of the e2e.Handler interface containing only the methods
// needed by GroupChat
type
e
2eHandler
interface
{
type
groupE
2eHandler
interface
{
SendE2E
(
mt
catalog
.
MessageType
,
recipient
*
id
.
ID
,
payload
[]
byte
,
params
e2e
.
Params
)
([]
id
.
Round
,
crypto
.
MessageID
,
time
.
Time
,
error
)
RegisterListener
(
senderID
*
id
.
ID
,
messageType
catalog
.
MessageType
,
...
...
This diff is collapsed.
Click to expand it.
groupChat/manager.go
+
3
−
3
View file @
aae656cd
...
...
@@ -47,11 +47,11 @@ type manager struct {
// Callback that is called when a new group request is received
requestFunc
RequestCallback
messenger
messenger
messenger
groupE2e
}
// NewManager creates a new group chat manager
func
NewManager
(
messenger
messenger
,
func
NewManager
(
messenger
groupE2e
,
requestFunc
RequestCallback
,
receiveFunc
Processor
)
(
GroupChat
,
error
)
{
// Initialize a member object
...
...
@@ -147,7 +147,7 @@ func (m *manager) getCMix() groupCmix {
return
m
.
messenger
.
GetCmix
()
}
func
(
m
*
manager
)
getE2eHandler
()
e
2eHandler
{
func
(
m
*
manager
)
getE2eHandler
()
groupE
2eHandler
{
return
m
.
messenger
.
GetE2E
()
}
...
...
This diff is collapsed.
Click to expand it.
groupChat/manager_test.go
+
2
−
2
View file @
aae656cd
...
...
@@ -31,8 +31,8 @@ var _ GroupChat = (*manager)(nil)
// Tests that groupCmix adheres to the cmix.Client interface.
var
_
groupCmix
=
(
cmix
.
Client
)(
nil
)
// Tests that
e
2eHandler adheres to the e2e.Handler interface.
var
_
e
2eHandler
=
(
e2eImport
.
Handler
)(
nil
)
// Tests that
groupE
2eHandler adheres to the e2e.Handler interface.
var
_
groupE
2eHandler
=
(
e2eImport
.
Handler
)(
nil
)
type
mockProcessor
struct
{
receiveChan
chan
MessageReceive
}
...
...
This diff is collapsed.
Click to expand it.
groupChat/messenger_test.go
+
3
−
3
View file @
aae656cd
...
...
@@ -15,7 +15,7 @@ import (
"testing"
)
// mockMessenger implementation for
messenger
interface
// mockMessenger implementation for
groupE2e
interface
type
mockMessenger
struct
{
receptionId
*
id
.
ID
net
cmix
.
Client
...
...
@@ -25,7 +25,7 @@ type mockMessenger struct {
storage
storage
.
Session
}
func
newMockMessenger
(
t
testing
.
TB
,
kv
*
versioned
.
KV
)
messenger
{
func
newMockMessenger
(
t
testing
.
TB
,
kv
*
versioned
.
KV
)
groupE2e
{
receptionId
:=
id
.
NewIdFromString
(
"test"
,
id
.
User
,
t
)
mockCmix
:=
newTestNetworkManager
(
0
)
prng
:=
rand
.
New
(
rand
.
NewSource
(
42
))
...
...
@@ -44,7 +44,7 @@ func newMockMessenger(t testing.TB, kv *versioned.KV) messenger {
}
}
func
newMockMessengerWithStore
(
t
testing
.
TB
,
sendErr
int
)
messenger
{
func
newMockMessengerWithStore
(
t
testing
.
TB
,
sendErr
int
)
groupE2e
{
receptionId
:=
id
.
NewIdFromString
(
"test"
,
id
.
User
,
t
)
mockCmix
:=
newTestNetworkManager
(
sendErr
)
prng
:=
rand
.
New
(
rand
.
NewSource
(
42
))
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment