Skip to content
Snippets Groups Projects
Commit f67757f4 authored by Benjamin Wenger's avatar Benjamin Wenger
Browse files

Merge branch 'hotfix/dont-clear-opstatus' into 'release'

Hotfix/ dont clear optatus and rekeychan

See merge request !343
parents 0e2464fd 8f68019f
No related branches found
No related tags found
No related merge requests found
...@@ -218,8 +218,6 @@ func (cl *Client) Logout(timeoutDuration time.Duration) error { ...@@ -218,8 +218,6 @@ func (cl *Client) Logout(timeoutDuration time.Duration) error {
cl.session = nil cl.session = nil
cl.receptionManager = nil cl.receptionManager = nil
cl.topology = nil cl.topology = nil
cl.opStatus = nil
cl.rekeyChan = nil
cl.registrationVersion = "" cl.registrationVersion = ""
return nil return nil
......
...@@ -616,14 +616,7 @@ func TestClient_LogoutHappyPath(t *testing.T) { ...@@ -616,14 +616,7 @@ func TestClient_LogoutHappyPath(t *testing.T) {
t.Logf("Topology should be set to nil on shutdown") t.Logf("Topology should be set to nil on shutdown")
t.Fail() t.Fail()
} }
if tc.opStatus != nil {
t.Logf("OPstatus should be set to nil on shutdown")
t.Fail()
}
if tc.rekeyChan != nil {
t.Logf("rekeyChan should be set to nil on shutdown")
t.Fail()
}
//Test that the things that should not be nil are not nil //Test that the things that should not be nil are not nil
if tc.ndf == nil { if tc.ndf == nil {
...@@ -634,6 +627,14 @@ func TestClient_LogoutHappyPath(t *testing.T) { ...@@ -634,6 +627,14 @@ func TestClient_LogoutHappyPath(t *testing.T) {
t.Logf("Storage should not be set to nil") t.Logf("Storage should not be set to nil")
t.Fail() t.Fail()
} }
if tc.opStatus == nil {
t.Logf("OPstatus should not be set to nil on shutdown")
t.Fail()
}
if tc.rekeyChan == nil {
t.Logf("rekeyChan should not be set to nil on shutdown")
t.Fail()
}
} }
//Test that the client shutdown will timeout when it fails to shutdown //Test that the client shutdown will timeout when it fails to shutdown
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment