Skip to content
Snippets Groups Projects

XX-4030 / Bindings Facts

Merged Jono Wenger requested to merge XX-4030/BindingsFacts into release
1 unresolved thread

Remove bindings-level Fact object and instead use fact.Fact and fact.FactList

Merge request reports

Approval is optional

Merged by Jake TaylorJake Taylor 2 years ago (Aug 10, 2022 6:30pm UTC)

Merge details

  • Changes merged into release with e30a6084 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
159 Fact: factsList[i].Fact,
160 T: fact.FactType(factsList[i].Type),
161 })
162 }
144 cnt.Facts = factsList
163 145
164 cnt.Facts = realFactList
165 146 return cnt.Marshal(), nil
166 147 }
167 148
168 // GetFactsFromContact accepts a marshalled contact.Contact object and returns
169 // its marshalled list of Fact objects.
149 // GetFactsFromContact returns the fact list in the contact.Contact object.
150 //
151 // Parameters:
152 // - marshaled - the JSON marshalled by of contact.Contact object.
  • Jono Wenger added 1 commit

    added 1 commit

    Compare with previous version

  • Jake Taylor mentioned in commit e30a6084

    mentioned in commit e30a6084

  • merged

  • Please register or sign in to reply
    Loading