Skip to content
Snippets Groups Projects

Add field RoundUrl to all send reporters in bindings

Merged Add field RoundUrl to all send reporters in bindings
XX-4126/BindingsRoundUrl into release
1 unresolved thread
Merged Josh Brooks requested to merge XX-4126/BindingsRoundUrl into release
1 unresolved thread

Merge request reports

Approval is optional

Merged by Josh BrooksJosh Brooks 2 years ago (Sep 8, 2022 5:25pm UTC)

Merge details

  • Changes merged into release with 12144ff4.
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
bindings/delivery.go
17 18 "gitlab.com/xx_network/primitives/id"
18 19 )
19 20
21 // dashboardBaseURL is the base of the xx network's round dashboard URL.
22 // This should be used by any type of send report's GetRoundURL method.
23 const dashboardBaseURL = "https://dashboard.xx.network"
  • Richard T. Carback III
  • Richard T. Carback III
    Richard T. Carback III @carback1 ·
    Maintainer

    LGTM. Non-required suggestion to make the base url changeable.

  • Josh Brooks added 1 commit

    added 1 commit

    Compare with previous version

  • Josh Brooks enabled an automatic merge when the pipeline for 57eecf61 succeeds

    enabled an automatic merge when the pipeline for 57eecf61 succeeds

  • Josh Brooks merged

    merged

  • Josh Brooks mentioned in commit 12144ff4

    mentioned in commit 12144ff4

    • Please register or sign in to reply