Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
comms
Manage
Activity
Members
Labels
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
elixxir
comms
Commits
9f38710c
Commit
9f38710c
authored
3 years ago
by
Josh Brooks
Browse files
Options
Downloads
Patches
Plain Diff
Fix further racey issue in tests
parent
3b95afbc
No related branches found
No related tags found
3 merge requests
!58
Revert "Modify waiting lock"
,
!9
Release
,
!6
Fix racy test
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
network/dataStructures/waitingRounds_test.go
+6
-9
6 additions, 9 deletions
network/dataStructures/waitingRounds_test.go
network/instance_test.go
+1
-1
1 addition, 1 deletion
network/instance_test.go
with
7 additions
and
10 deletions
network/dataStructures/waitingRounds_test.go
+
6
−
9
View file @
9f38710c
...
@@ -269,15 +269,12 @@ func TestWaitingRounds_GetUpcomingRealtime_GetFurthest(t *testing.T) {
...
@@ -269,15 +269,12 @@ func TestWaitingRounds_GetUpcomingRealtime_GetFurthest(t *testing.T) {
// Populate the waiting rounds
// Populate the waiting rounds
for
i
,
round
:=
range
expectedRounds
{
for
i
,
round
:=
range
expectedRounds
{
localIndex
:=
i
go
func
(
round
*
Round
,
index
int
)
{
time
.
Sleep
(
30
*
time
.
Millisecond
)
time
.
Sleep
(
30
*
time
.
Millisecond
)
err
:=
testutils
.
SignRoundInfoRsa
(
round
.
info
,
t
)
err
:=
testutils
.
SignRoundInfoRsa
(
round
.
info
,
t
)
if
err
!=
nil
{
if
err
!=
nil
{
t
.
Errorf
(
"Failed to sign round info #%d: %+v"
,
localIndex
,
err
)
t
.
Errorf
(
"Failed to sign round info #%d: %+v"
,
i
,
err
)
}
}
testWR
.
Insert
(
round
)
testWR
.
Insert
(
round
)
}(
round
,
localIndex
)
}
}
// Attempt to get the furthest round in the queue
// Attempt to get the furthest round in the queue
...
...
This diff is collapsed.
Click to expand it.
network/instance_test.go
+
1
−
1
View file @
9f38710c
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment