Fix transition bug when the keyboard is presented

This MR improves the transition when navigating from a screen while presenting keyboard.

This should fix the issue: [Registration] UI transition bug when having the keyboard enabled.

What was done

• Refactor code that loads view in OnboardingCodeController and ProfileCodeController:
  • Make sure the view and layout are set up correctly.
  • Avoid using SnapKit.
  • When finished initial setup, call setNeedsLayout and layoutIfNeeded so the view is laid out immediately.
• Dismiss the keyboard on OnboardingPhoneController and ProfilePhoneController before navigating to next screen.

Dismissing the keyboard is not mandatory, but I think it helps to achieve a visually satisfying transition.

Preview

Before	After (fix layout)	After (fix layout + dismiss keyboard)
before	after-1	after-2

Sources/OnboardingFeature/Controllers/OnboardingCodeController.swift

@@ -73,12 +73,20 @@ public final class OnboardingCodeController: UIViewController {
   }
 
   private func setupScrollView() {
+    scrollViewController.contentView = screenView
+    scrollViewController.scrollView.backgroundColor = Asset.neutralWhite.color
     addChild(scrollViewController)
     view.addSubview(scrollViewController.view)
-    scrollViewController.view.snp.makeConstraints { $0.edges.equalToSuperview() }
+    scrollViewController.view.translatesAutoresizingMaskIntoConstraints = false
+    NSLayoutConstraint.activate([
+      scrollViewController.view.topAnchor.constraint(equalTo: view.topAnchor),
+      scrollViewController.view.bottomAnchor.constraint(equalTo: view.bottomAnchor),
+      scrollViewController.view.leftAnchor.constraint(equalTo: view.leftAnchor),
+      scrollViewController.view.rightAnchor.constraint(equalTo: view.rightAnchor),
+    ])
+    view.setNeedsLayout()
+    view.layoutIfNeeded()
     scrollViewController.didMove(toParent: self)
-    scrollViewController.contentView = screenView
-    scrollViewController.scrollView.backgroundColor = Asset.neutralWhite.color
   }
 
   private func setupBindings() {