Skip to content
Snippets Groups Projects
Commit aa2c6878 authored by Josh Brooks's avatar Josh Brooks
Browse files

Remove FIXME notes for tracking kv.Set version mismatching

parent 22a21b47
No related branches found
No related tags found
3 merge requests!510Release,!364Modify KV.Set to no longer contain version parameter,!354Channels impl
...@@ -53,8 +53,6 @@ func (*meteredCmixMessageHandler) SaveMessage(kv *versioned.KV, m interface{}, ...@@ -53,8 +53,6 @@ func (*meteredCmixMessageHandler) SaveMessage(kv *versioned.KV, m interface{},
} }
// Save versioned object // Save versioned object
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
return kv.Set(key, &obj) return kv.Set(key, &obj)
} }
......
...@@ -72,8 +72,6 @@ func (r *registrar) save() error { ...@@ -72,8 +72,6 @@ func (r *registrar) save() error {
Data: data, Data: data,
} }
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
return r.kv.Set(storeKey, &obj) return r.kv.Set(storeKey, &obj)
} }
......
...@@ -34,8 +34,6 @@ func savePart(kv *versioned.KV, partNum uint8, part []byte) error { ...@@ -34,8 +34,6 @@ func savePart(kv *versioned.KV, partNum uint8, part []byte) error {
Timestamp: netTime.Now(), Timestamp: netTime.Now(),
Data: part, Data: part,
} }
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
return kv.Set(key, &obj) return kv.Set(key, &obj)
} }
......
...@@ -45,8 +45,6 @@ func storeRelationshipFingerprint(fp []byte, kv *versioned.KV) error { ...@@ -45,8 +45,6 @@ func storeRelationshipFingerprint(fp []byte, kv *versioned.KV) error {
Data: fp, Data: fp,
} }
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
return kv.Set(relationshipFingerprintKey, &obj) return kv.Set(relationshipFingerprintKey, &obj)
} }
......
...@@ -151,8 +151,6 @@ func (u *User) SetRegistrationTimestamp(tsNano int64) { ...@@ -151,8 +151,6 @@ func (u *User) SetRegistrationTimestamp(tsNano int64) {
Data: tsBytes, Data: tsBytes,
} }
// fixme: this had differing versions in object and set,
// reviewer please confirm this is correct before merge
err := u.kv.Set(registrationTimestampKey, obj) err := u.kv.Set(registrationTimestampKey, obj)
if err != nil { if err != nil {
jww.FATAL.Panicf("Failed to store the reception timestamp: %s", err) jww.FATAL.Panicf("Failed to store the reception timestamp: %s", err)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment