Skip to content
Snippets Groups Projects
Commit dab666dd authored by Jonah Husson's avatar Jonah Husson
Browse files

remove comment, fix generateIdentities test

parent 0e5663a2
No related branches found
No related tags found
2 merge requests!23Release,!17Fix grace period use
......@@ -141,16 +141,13 @@ func generateIdentities(protoIds []ephemeral.ProtoIdentity, ourId *id.ID,
// Add identities for every ephemeral ID
for i, eid := range protoIds {
// Expand the grace period for both start and end
// This does not actually modify anything.... time is not a pointer and even if it were this returns the new value???
// eid.End.Add(validityGracePeriod)
// eid.Start.Add(-validityGracePeriod)
identities[i] = reception.Identity{
EphId: eid.Id,
Source: ourId,
AddressSize: addressSize,
End: eid.End,
StartValid: eid.Start.Add(-validityGracePeriod),
EndValid: eid.End.Add(validityGracePeriod), // What is this vs end? should it be modified??
EndValid: eid.End.Add(validityGracePeriod),
Ephemeral: false,
}
......
......@@ -131,7 +131,7 @@ func TestGenerateIdentities(t *testing.T) {
}
protoIds := []ephemeral.ProtoIdentity{{eid, s, e}}
generated := generateIdentities(protoIds, id.NewIdFromString("escaline", id.Node, t), 16)
if generated[0].End != protoIds[0].End.Add(5*time.Minute) {
if generated[0].EndValid != protoIds[0].End.Add(5*time.Minute) {
t.Errorf("End was not modified. Orig %+v, Generated %+v", protoIds[0].End, generated[0].End)
}
if generated[0].StartValid != protoIds[0].Start.Add(-5*time.Minute) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment